[embind] Add pointer policies for val's call, operator(), and new_. #24832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewer: The first commit is just moving policy code into wire.h, so it's probably easier to look at the second commit on its own. |
brendandahl
force-pushed
the
embind-call-policy
branch
from
84962cb to
1c165b0
Compare
|
@sbc or @RReverser mind taking a look? The changes ignorning the moved code are relatively small 01eafbe |
|
So does this mean some code now will not work of behave differently under C++11 vs C++17? I wonder if we should document this or mention in the changelog? |
sbc100
reviewed
Sep 3, 2025
system/include/emscripten/val.h
Outdated
| using Policy = WithPolicies<FilterTypes<isPolicy, Args...>>; | ||
| auto filteredArgs = Filter<isNotPolicy>(args...); | ||
| return std::apply( | ||
| [&](auto&&... filteredArgs) -> decltype(auto) { |
There was a problem hiding this comment.
Should we name filteredArgs differently here so it doesn't shadow the outer filteredArgs 2 lines up?
…w_`. After emscripten-core#24175, pointer policies were required in more places, but there was no way to pass the policy into val's `call`, `operator()`, and `new_` methods and use pointers. All of these methods take variadic template arguments already which made passing separate variadic policy arguments challenging. I used some C++14/17 tricks to separate the regular arguments and policy arguments.
brendandahl
force-pushed
the
embind-call-policy
branch
from
1c165b0 to
793d255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #24175, pointer policies were required in more places, but there
was no way to pass the policy into val's
call,operator(), andnew_methods and use pointers.
All of these methods take variadic template arguments already
which made passing separate variadic policy arguments challenging. I used
some C++14/17 tricks to separate the regular arguments and policy
arguments.
Fixes #24398